Skip to content

dcc: refactor input #3398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: dev
Choose a base branch
from
Draft

dcc: refactor input #3398

wants to merge 7 commits into from
+1,368 −7,763

Conversation

KoolADE85
Copy link
Contributor

@KoolADE85 KoolADE85 commented Aug 8, 2025 •
edited
Loading

This PR add scaffolding to write dcc components in Typescript.
It refactors the Input dcc component to be a function-component written in Typescript and with new CSS rules applied.

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • task 1
    • task 2
  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
    • this GitHub #PR number updates the dash docs
    • here is the show and tell thread in Plotly Dash community

@KoolADE85 KoolADE85 force-pushed the feature/dcc-refactor-input branch from 2b47c08 to 5a49f13 Compare August 8, 2025 23:22
@KoolADE85 KoolADE85 changed the title Feature/dcc refactor input dcc: refactor input Aug 8, 2025
@KoolADE85 KoolADE85 force-pushed the feature/dcc-refactor-input branch 2 times, most recently from d7fa1ac to 01dac37 Compare August 11, 2025 16:36
@KoolADE85 KoolADE85 force-pushed the feature/dcc-refactor-input branch from 01dac37 to 1653281 Compare August 11, 2025 17:01
@gvwilson gvwilson added P1 needed for current cycle fix fixes something broken labels Aug 11, 2025
KoolADE85
KoolADE85 commented Aug 12, 2025
View reviewed changes
dash/development/_generate_prop_types.py Outdated
values = str([v["value"] for v in prop_info["value"]])
return f"pt.oneOf({values})"
values = [v["value"] for v in prop_info["value"] if v.get("value") is not None]
return f"pt.oneOf([{",".join(v for v in values)}])"
Copy link
Contributor Author

@KoolADE85 KoolADE85 Aug 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes doubly-quoted strings in an enum of string literals

@KoolADE85 KoolADE85 force-pushed the feature/dcc-refactor-input branch 2 times, most recently from ffdf944 to 99e0e91 Compare August 12, 2025 22:48
@KoolADE85 KoolADE85 force-pushed the feature/dcc-refactor-input branch from 99e0e91 to 7ec85f3 Compare August 12, 2025 23:24
@KoolADE85 KoolADE85 force-pushed the feature/dcc-refactor-input branch from 1b336c2 to 0c175f5 Compare August 12, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T4rk1n T4rk1n Awaiting requested review from T4rk1n T4rk1n will be requested when the pull request is marked ready for review T4rk1n is a code owner

@ndrezn ndrezn Awaiting requested review from ndrezn ndrezn will be requested when the pull request is marked ready for review ndrezn is a code owner

@gvwilson gvwilson Awaiting requested review from gvwilson gvwilson will be requested when the pull request is marked ready for review gvwilson is a code owner

@emilykl emilykl Awaiting requested review from emilykl emilykl will be requested when the pull request is marked ready for review emilykl is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@KoolADE85 KoolADE85

Labels
fix fixes something broken P1 needed for current cycle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KoolADE85 @gvwilson